Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Drain response after every chunk write in StaticRoute. #501

Closed
wants to merge 1 commit into from
Closed

Drain response after every chunk write in StaticRoute. #501

wants to merge 1 commit into from

Conversation

jashandeep-sohi
Copy link
Contributor

Shouldn't the handler for StaticRoutes give control over to the event loop after writing each chunk, so that the event loop doesn't block? Or, am I missing something?

@asvetlov
Copy link
Member

Agree in general.
But it brings another question: what is reasonable size for chunk?
Now it is 256Kb.
For modern operation systems it may be 1..8 MB at least.

But please take a look on #398 -- sendfile can solve the issue even better.
Would you work on sendfile approach?

@jashandeep-sohi
Copy link
Contributor Author

Yes, I'm already working on sendfile support ;)
That's how I ended up looking at the StaticRoute handler.

I'll post a first draft soon.

@asvetlov
Copy link
Member

Fixed by #503

@asvetlov asvetlov closed this Sep 15, 2015
@jashandeep-sohi jashandeep-sohi deleted the staticroute branch September 18, 2015 01:05
@lock
Copy link

lock bot commented Oct 30, 2019

This thread has been automatically locked since there has not been
any recent activity after it was closed. Please open a new issue for
related bugs.

If you feel like there's important points made in this discussion,
please include those exceprts into that new issue.

@lock lock bot added the outdated label Oct 30, 2019
@lock lock bot locked as resolved and limited conversation to collaborators Oct 30, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
outdated
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jashandeep-sohi @asvetlov